Review Request 115357: Add a shortcut for copying current directory

Frank Reininghaus frank78ac at googlemail.com
Tue Jan 28 15:58:47 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115357/#review48484
-----------------------------------------------------------


First of all, thanks for the patch!

To quote my comment https://bugs.kde.org/show_bug.cgi?id=323960#c3 :

"...this is one of the cases where I wonder if this feature is really useful enough that it justifies adding code which must be maintained in the future, and adding another action that makes the shortcuts dialog harder to use (I admit that it's a big mess not not very useable already)."

- Frank Reininghaus


On Jan. 28, 2014, 3:55 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115357/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 3:55 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 323960
>     http://bugs.kde.org/show_bug.cgi?id=323960
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Add 2 shortcuts as described in
> https://bugs.kde.org/show_bug.cgi?id=323960
> 
> 1. Copy current URL to Clipboard
>   Default Shortcut: Ctrl-Alt-C
> 
> 2. Set current Url to the one in Clipboard
>   Default Shortcut: Ctrl-Alt-D (Because Ctrl-Alt-V is occupied by Klipper, D could be understood as "dispatch" maybe..
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 6b046c2 
>   dolphin/src/dolphinmainwindow.cpp a4dbb6f 
> 
> Diff: https://git.reviewboard.kde.org/r/115357/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140128/906add76/attachment.htm>


More information about the kfm-devel mailing list