Review Request 115064: Use only one "directory contents counting" thread per process

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115064/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 6:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Since https://git.reviewboard.kde.org/r/111920/, we use a separate thread for counting the items inside directories (e.g., for the "Size" column in Details View) to prevent that the GUI is blocked while handling large directories. However, this means that Dolphin now uses quite a lot of threads if there are many views. To see that, run Dolphin in gdb, open many tabs with Ctrl+T, and check the output of "thread apply all backtrace.

I propose to make all views share the same thread. The QThread object is stored in a global variable, and each view increments/decrements a reference count when it starts/stops using the thread. If this thread reaches zero, the thread is stopped.


Diffs
-----

  dolphin/src/kitemviews/private/kdirectorycontentscounter.h 425c363 
  dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp fd8479f 

Diff: https://git.reviewboard.kde.org/r/115064/diff/


Testing
-------

Opening new views does not start new threads any more. The "Size" column in Details view still works normally for me.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140121/5cbf3ceb/attachment.htm>