Review Request 114992: Remove the "retrieved items" stuff from UpdateItemStatesThread and VersionControlObserver.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114992/#review47488
-----------------------------------------------------------

Ship it!


OK, thanks for the explanations! It's always great to see that some problems can be solved just by removing code :-)

- Frank Reininghaus


On Jan. 12, 2014, 10:59 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114992/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 10:59 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Remove the "retrieved items" stuff from UpdateItemStatesThread and VersionControlObserver.
> 
> Showing an error message, makes no sense in this case, because the user can see it, when the update of version information failed.
> 
> The plugins still have the ability to show error/warning messages on real errors. (where it makes sense ;)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.h 2914bc2 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 6be07d3 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 4d939ee 
> 
> Diff: https://git.reviewboard.kde.org/r/114992/diff/
> 
> 
> Testing
> -------
> 
> Works.
> No random "Update of version infromation failed." errors in version controlled folders anymore.
> 
> With enabled dolphin-dropbox-plugin:
> No "Update of version infromation failed." when dropbox is not running.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140116/b4cb799a/attachment.htm>