Review Request 114957: Add support for getting a samba share's total size and free space through KIO, dolphin part

[David Faure]

> On Jan. 10, 2014, 11:41 p.m., David Faure wrote:
> > Thanks :)
> > 
> > You don't seem to have a contributor account? Can the Dolphin developers commit the patch then? (I see it has to be coordinated with the kio_smb patch, too)
> 
> Mathias Tillman wrote:
>     I don't have a contributor account no, and yes, this depends on the new kio_smb code.
>     Did you look through the kio code too? The file I changed (kio_smb_mount.cpp) doesn't seem to follow the current coding styles, so I just tried to make it look like the other code.
>     
>     Also, the "Depends On" line keeps getting removed for me even though I never touched it after first committing the review, is this a bug?
> 
> Frank Reininghaus wrote:
>     I still don't think that this is a good idea. Am I the only one who thinks that making an application shout "5" and expecting that the kioslave sends the free space is bad design?
> 
> Emmanuel Pescosta wrote:
>     > I still don't think that this is a good idea.
>     +1 from my side
>     
>     Hmm we can use this patch as a Dolphin 4.x only solution, but with KF5 this should definitely go into a proper library.
> 
> Mathias Tillman wrote:
>     Frank, no, I agree. This is bad design. I think that there should be a standard kio call that retrieves the total space and free space for all kio types (instead of using KFreeDiskSpaceInfo). If this is something you all agree on I will have a look at implementing it. I didn't want to mess around with the API too much, which is another reason I implemented it as a special call (since that doesn't change the API at all).

Good idea, make it a proper KIO::Job in KIOCore in KF5.
You can use mkdirjob.* as an example, for instance.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/#review47177
-----------------------------------------------------------


On Jan. 10, 2014, 11:35 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114957/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 11:35 p.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command. This is the dolphin part of the code, see #114956 for the other part.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/statusbarspaceinfo.h 1849462 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833 
> 
> Diff: https://git.reviewboard.kde.org/r/114957/diff/
> 
> 
> Testing
> -------
> 
> I have tried browsing samba shares. I have not, however, done a lot of error checking (network down etc). But the code should be ready for that.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140113/d3c12d9b/attachment.htm>