Review Request 114957: Add support for getting a samba share's total size and free space through KIO, dolphin part

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/#review47173
-----------------------------------------------------------


Almost there, mostly coding style stuff.


dolphin/src/statusbar/statusbarspaceinfo.h
<https://git.reviewboard.kde.org/r/114957/#comment33631>

    the default values are not useful (and therefore confusing), this method is always called with 3 arguments



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33632>

    space after if



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33633>

    no space inside ( ... )



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33634>

    remove space after connect(



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33635>

    sorry for being picky, I'd just call that "info", not "anything job". It contains the info already, no job needed.



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33636>

    the rule about '{' placement applies to all methods ;)



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33637>

    wrong '{' placement



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/114957/#comment33638>

    space after if


- David Faure


On Jan. 10, 2014, 11:17 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114957/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 11:17 p.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command. This is the dolphin part of the code, see #114956 for the other part.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/statusbarspaceinfo.h 1849462 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833 
> 
> Diff: https://git.reviewboard.kde.org/r/114957/diff/
> 
> 
> Testing
> -------
> 
> I have tried browsing samba shares. I have not, however, done a lot of error checking (network down etc). But the code should be ready for that.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140110/32e03d17/attachment.htm>