Review Request 114957: Add support for getting a samba share's total size and free space through KIO, dolphin part

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114957/#review47164
-----------------------------------------------------------


Thanks for the patch. Your work on this feature is appreciated, but I'm not sure if this is the right way to approach the problem. Starting a "special" job from an application and passing undocumented magic values as parameters is not exactly the best way to write readable, maintainable and future-proof code. Moreover, I don't like that there are two protocol-specific ways to obtain the free space (for "file" and "smb").

IMHO, there should be some API in KIO that can be used to determine the free size for both protocols (and maybe more in the future). You might want to discuss this with David Faure and Dawit, who are the major KIO contributors.

- Frank Reininghaus


On Jan. 10, 2014, 6:22 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114957/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 6:22 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command. This is the dolphin part of the code, see #114956 for the other part.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/statusbarspaceinfo.h 1849462 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 61b2833 
> 
> Diff: https://git.reviewboard.kde.org/r/114957/diff/
> 
> 
> Testing
> -------
> 
> I have tried browsing samba shares. I have not, however, done a lot of error checking (network down etc). But the code should be ready for that.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140110/7208cf71/attachment.htm>