Review Request 114812: KVersionControlPlugin2 based Dropbox version control plugin for Dolphin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114812/
-----------------------------------------------------------

(Updated Jan. 10, 2014, 10:51 a.m.)


Review request for Dolphin.


Changes
-------

Use String::fromUtf8 for the received data, because Dropbox returns utf8-encoded strings.

Got feedback from Sergey, he'll give some comments about this patch ;)


Bugs: 298199
    http://bugs.kde.org/show_bug.cgi?id=298199


Repository: dolphin-plugins


Description
-------

Added a Dropbox version control plugin for Dolphin.

This Dropbox plugin is based on the work of:
Sergei Stolyarovs - https://bitbucket.org/cancel/dolphin-dropbox-plugin
Thomas Richards - http://trichard-kde.blogspot.co.at/2010/12/introducing-dropbox-integration-for.html

What I have done:
- Ported the old source code to the newer KVersionControlPlugin2 interface
- Use the Dropbox client to form the context menu more dynamically
  (If the Dropbox guys add a new feature to their client, Dolphin can make use of it automatically)
- Fixed a crash (Dolphin-4.8.2 segfaults when a file with special characters is present)
- Replaced the item version changed timer with a file system watcher -> No useless updates every 10 seconds and immediate update on real changes
- A lot of code/coding style related changes

I think that this plugin is small enough to include it into the official Dolphin-plugins collection. ;)


Diffs (updated)
-----

  CMakeLists.txt 4d87420 
  dropbox/CMakeLists.txt PRE-CREATION 
  dropbox/Messages.sh PRE-CREATION 
  dropbox/fileviewdropboxplugin.cpp PRE-CREATION 
  dropbox/fileviewdropboxplugin.desktop PRE-CREATION 
  dropbox/fileviewdropboxplugin.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114812/diff/


Testing
-------

Works fine for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140110/a4270d1b/attachment.htm>