Review Request 114812: KVersionControlPlugin2 based Dropbox version control plugin for Dolphin

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114812/#review46749
-----------------------------------------------------------


Thanks for improving the Dropbox plugin! I'm sure that many users will appreciate this. I think I remember that people even mentioned that Thomas' plugin has not been working any more after some changes in the Dropbox client?

Did you get in touch with Sergei and Thomas? I think it would be good to let them know that their code is used in a plugin that is hosted on git.kde.org. They might also be able to help in the future with improving the plugin, and maybe they can also comment on the patch because they are probably more familiar with Dropbox than most people who read kfm-devel.

In the case of Thomas, I think it would also be important to contact him because we currently have the Dolphin component "plugins-dropbox" at bugs.kde.org which is assigned to him.

- Frank Reininghaus


On Jan. 2, 2014, 4:16 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114812/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2014, 4:16 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 298199
>     http://bugs.kde.org/show_bug.cgi?id=298199
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Added a Dropbox version control plugin for Dolphin.
> 
> This Dropbox plugin is based on the work of:
> Sergei Stolyarovs - https://bitbucket.org/cancel/dolphin-dropbox-plugin
> Thomas Richards - http://trichard-kde.blogspot.co.at/2010/12/introducing-dropbox-integration-for.html
> 
> What I have done:
> - Ported the old source code to the newer KVersionControlPlugin2 interface
> - Use the Dropbox client to form the context menu more dynamically
>   (If the Dropbox guys add a new feature to their client, Dolphin can make use of it automatically)
> - Fixed a crash (Dolphin-4.8.2 segfaults when a file with special characters is present)
> - Replaced the item version changed timer with a file system watcher -> No useless updates every 10 seconds and immediate update on real changes
> - A lot of code/coding style related changes
> 
> I think that this plugin is small enough to include it into the official Dolphin-plugins collection. ;)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4d87420 
>   dropbox/CMakeLists.txt PRE-CREATION 
>   dropbox/Messages.sh PRE-CREATION 
>   dropbox/fileviewdropboxplugin.cpp PRE-CREATION 
>   dropbox/fileviewdropboxplugin.desktop PRE-CREATION 
>   dropbox/fileviewdropboxplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114812/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140104/28330621/attachment.htm>