Review Request 112567: Move the tab-handling away from DolphinMainWindow (Patch-Series)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112567/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 12:24 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Move the tab-handling away from DolphinMainWindow (Patch-Series)
    
Removed all code in DolphinMainWindow which is related to tabbed browsing,
except of some functions/slots which are required for the current UI, like
openNewTab(), openInNewTab(), ...
    
The tab-handling will be implemented again in another patch.

Split View and Tabbed Browsing will not work anymore with this patch!


Diffs
-----

  dolphin/src/dolphinmainwindow.h 7da5801 
  dolphin/src/dolphinmainwindow.cpp 4128cdf 

Diff: https://git.reviewboard.kde.org/r/112567/diff/


Testing
-------

Split View and Tabbed Browsing doesn't work (is ok)

Everything else works fine for me (Only one view)


File Attachments
----------------

Overview
  https://git.reviewboard.kde.org/media/uploaded/files/2013/09/11/dolphin_tab_handling.svg


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140228/f633df83/attachment.htm>