Review Request 116118: Set the focus to the active view, after leaving the terminal panel.

Frank Reininghaus frank78ac at googlemail.com
Thu Feb 27 14:23:01 GMT 2014



> On Feb. 27, 2014, 2:14 p.m., Frank Reininghaus wrote:
> > Thanks for looking into this.
> > 
> > What happens if the user switches to another virtual desktop and then back to the one showing the Dolphin window? If the view is focused also in that case, then this is probably not what the user wants.
> 
> Emmanuel Pescosta wrote:
>     Focus is still in the terminal panel.
> 
> Emmanuel Pescosta wrote:
>     Btw. the places panel uses the same signal to enable/disable the places selector of the url navigator.
>     
>     So I think it should not introduce any bugs, related to activity/virtual desktop/... switching. ;)

Here it's not, the view gets the focus.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116118/#review51052
-----------------------------------------------------------


On Feb. 27, 2014, 2:05 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116118/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 2:05 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 298467
>     http://bugs.kde.org/show_bug.cgi?id=298467
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Set the focus to the active view, after leaving the terminal panel.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
> 
> Diff: https://git.reviewboard.kde.org/r/116118/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140227/aec1f1b1/attachment.htm>


More information about the kfm-devel mailing list