Review Request 116119: Fix inconsistent keyboard navigation/focus handling while inline renaming.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116119/#review51054
-----------------------------------------------------------


Thanks for looking into this, but I'm afraid it's not that easy to fix this.

The point of the 'if' check is the following:

1. Open Dolphin, split the view.
2. Rename an item in the left view.
3. Click the right view.
4. The right view should have the focus now.

If I'm not mistaken, the left view will steal the focus back if your patch is applied.

- Frank Reininghaus


On Feb. 27, 2014, 2:07 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116119/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 2:07 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 253488
>     http://bugs.kde.org/show_bug.cgi?id=253488
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix inconsistent keyboard navigation/focus handling while inline renaming.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9f7b269 
> 
> Diff: https://git.reviewboard.kde.org/r/116119/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140227/1c04f843/attachment.htm>