Review Request 116019: Fix Bug 330605 - Dropbox plugin prevents git plugin from working

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Feb 24 20:38:26 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116019/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 9:38 p.m.)


Review request for Dolphin.


Changes
-------

Remove QMultiMap and use a simpler solution instead.

Is it safe enough for KDE 4.12?

*tomorrow = immediately ;)


Bugs: 330605
    http://bugs.kde.org/show_bug.cgi?id=330605


Repository: kde-baseapps


Description
-------

Fix Bug 330605 - Dropbox plugin prevents git plugin from working

Use scoring to find the best matching plugin for the given directory.

Instead of just returning the first matching plugin (upUrl case),
add it to the map and find the best matching plugin afterwards.


Diffs (updated)
-----

  dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 36345d9 

Diff: https://git.reviewboard.kde.org/r/116019/diff/


Testing
-------

I can't reproduce the bug, so I can't test if it really works.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140224/78f316be/attachment.htm>


More information about the kfm-devel mailing list