Review Request 116028: Add a hover effect for the selection toggle.
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Mon Feb 24 17:27:01 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116028/
-----------------------------------------------------------
Review request for Dolphin.
Bugs: 299328
http://bugs.kde.org/show_bug.cgi?id=299328
Repository: kde-baseapps
Description
-------
Add a hover effect for the selection toggle.
The KItemListController handles all hover events, so we can't use the hoverMoveEvent in the KItemListWidget directly.
Instead, if the current widget is valid, we set the widget hover position in KItemListController::hoverMoveEvent, so that the widget can react on it.
KItemListSelectionToggle has setHovered instead of hoverEnterEvent/hoverLeaveEvent now, we set the hover state in
KItemListWidget::setHoverPosition.
The icon state toggles now between ActiveState and DisabledState (I hope these are the right states for this usecase)
Diffs
-----
dolphin/src/kitemviews/kitemlistcontroller.cpp 7344b99
dolphin/src/kitemviews/kitemlistwidget.h 954629d
dolphin/src/kitemviews/kitemlistwidget.cpp 85cd70c
dolphin/src/kitemviews/private/kitemlistselectiontoggle.h ba29293
dolphin/src/kitemviews/private/kitemlistselectiontoggle.cpp 6bbf3c2
Diff: https://git.reviewboard.kde.org/r/116028/diff/
Testing
-------
Works.
Thanks,
Emmanuel Pescosta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140224/2042109e/attachment.htm>
More information about the kfm-devel
mailing list