Review Request 115958: Handle font and palette changes in Dolphin list views

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115958/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 1:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 315061 and 329186
    http://bugs.kde.org/show_bug.cgi?id=315061
    http://bugs.kde.org/show_bug.cgi?id=329186


Repository: kde-baseapps


Description
-------

Handle font and palette changes in Dolphin list views.

Also update the font of the meta data widget in InformationPanelContent (smallest readable font).

DolphinItemListView already had a function updateFont(), I made it virtual protected and implemented the "base" function in KItemListView.

DolphinItemListView::updateFont() uses the custom font, if enabled, otherwise it falls back to KItemListView::updateFont(), to update the view.
KItemListView::updateFont() always uses the system font.

Also implemented (protected virtual) KItemListView::updatePalette() to handle color scheme changes.


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.h f39e73a 
  dolphin/src/kitemviews/kitemlistview.cpp 82f8a20 
  dolphin/src/panels/information/informationpanelcontent.cpp b2dd158 
  dolphin/src/views/dolphinitemlistview.h 18bb284 
  dolphin/src/views/dolphinitemlistview.cpp 4799d76 

Diff: https://git.reviewboard.kde.org/r/115958/diff/


Testing
-------

Changing the color theme works.
Changing the font works.
Changing the font + custom font in Dolphin works.
Set the custom font back to system font in Dolphin, after the system font was updated, works.

So I think all cases work ;)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140224/fd38171b/attachment.htm>