Review Request 115958: Handle font and palette changes in Dolphin list views

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115958/#review50686
-----------------------------------------------------------

Ship it!


Cool, thanks for working on this! Looks very good to me.

I would use first(), rather than at(0), to get the first item of a QList, but it's a matter of taste. Feel free to push it either way.

- Frank Reininghaus


On Feb. 22, 2014, 8:33 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115958/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 8:33 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 315061 and 329186
>     http://bugs.kde.org/show_bug.cgi?id=315061
>     http://bugs.kde.org/show_bug.cgi?id=329186
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Handle font and palette changes in Dolphin list views.
> 
> Also update the font of the meta data widget in InformationPanelContent (smallest readable font).
> 
> DolphinItemListView already had a function updateFont(), I made it virtual protected and implemented the "base" function in KItemListView.
> 
> DolphinItemListView::updateFont() uses the custom font, if enabled, otherwise it falls back to KItemListView::updateFont(), to update the view.
> KItemListView::updateFont() always uses the system font.
> 
> Also implemented (protected virtual) KItemListView::updatePalette() to handle color scheme changes.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.h f39e73a 
>   dolphin/src/kitemviews/kitemlistview.cpp 82f8a20 
>   dolphin/src/panels/information/informationpanelcontent.cpp b2dd158 
>   dolphin/src/views/dolphinitemlistview.h 18bb284 
>   dolphin/src/views/dolphinitemlistview.cpp 4799d76 
> 
> Diff: https://git.reviewboard.kde.org/r/115958/diff/
> 
> 
> Testing
> -------
> 
> Changing the color theme works.
> Changing the font works.
> Changing the font + custom font in Dolphin works.
> Set the custom font back to system font in Dolphin, after the system font was updated, works.
> 
> So I think all cases work ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140224/fc46c761/attachment.htm>