Review Request 115720: Merged DolphinMainWindow::openDirectories() and DolphinMainWindow::openFiles() -> DolphinMainWindow::openUrls()

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115720/#review49795
-----------------------------------------------------------



dolphin/src/dolphinviewcontainer.h
<https://git.reviewboard.kde.org/r/115720/#comment35001>

    I'll add a comment here


- Emmanuel Pescosta


On Feb. 13, 2014, 1:10 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115720/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 1:10 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Merged DolphinMainWindow::openDirectories() and DolphinMainWindow::openFiles() -> DolphinMainWindow::openUrls()
> 
> We use the given url now and extract the directory and item url. If the item url is valid, we mark
> the file as current.
> 
> --select console arg is now obsolete, because you can simply write the full url instead. (e.g. /home/konq/me.png)
> 
> Open path in new tab/window also make use of these changes, files opened from search queries are now
> marked as current in the new tab/window.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinapplication.cpp 8e83a85 
>   dolphin/src/dolphinmainwindow.h cb97612 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
>   dolphin/src/dolphinviewcontainer.h 31612f1 
>   dolphin/src/dolphinviewcontainer.cpp 768fd5e 
> 
> Diff: https://git.reviewboard.kde.org/r/115720/diff/
> 
> 
> Testing
> -------
> 
> dolphin -> opens home dir
> dolphin "/home/emmanuel/Downloads/Aufgabe.pdf" -> opens Downloads, marks Aufgabe.pdf
> dolphin "tags:/Kde" -> opens tags:/Kde
> dolphin "/home/emmanuel/zipped.zip" -> opens "zip:/home/emmanuel/zipped.zip"
> 
> searching something and open path in new tab, openes folder and marks file.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140214/84a51328/attachment.htm>