Review Request 115627: Remove some unused functions

Frank Reininghaus frank78ac at googlemail.com
Mon Feb 10 15:05:01 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115627/#review49453
-----------------------------------------------------------

Ship it!


Makes sense, thanks :-)

- Frank Reininghaus


On Feb. 10, 2014, 2:48 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115627/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 2:48 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Remove some unused functions.
> 
> void KFileItemModel::slotClear(const KUrl& url)
> 
> bool UpdateItemsThread::lockPlugin()    <- Done with QMutexLocker
> void UpdateItemsThread::unlockPlugin()
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 7cdc160 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.h 0e92a4c 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 6bc3890 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 62f0ec2 
> 
> Diff: https://git.reviewboard.kde.org/r/115627/diff/
> 
> 
> Testing
> -------
> 
> Compiles and works fine
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140210/9c602c4b/attachment.htm>


More information about the kfm-devel mailing list