Review Request 115612: Apply zoom level to font size.

Frank Reininghaus frank78ac at googlemail.com
Mon Feb 10 08:09:48 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115612/#review49420
-----------------------------------------------------------


First of all, thanks for the patch.

Has there been any discussion about this idea, maybe with usability or accessibility experts? If yes, please provide a link.

>From my point of view, you are trying to address a valid problem (the text is too small to read), but the solution is wrong. If a user cannot read the text, then they should adjust the font size in the settings, or even better, adjust their KDE-wide font settings and do not use any application-specific font settings.

I see no reason to believe that the average user also wants an increased font size if they change the icon size. Note that the icon size can be chosen differently for each view mode and for the case that previews are enabled or disabled. Why should the font size be different for these cases?

Moreover, the user may want to increase the icon size temporarily if they want to see a bit more detail in the previews for a number of images in a directory. It is very unlikely that a larger font is also wanted in that case.


- Frank Reininghaus


On Feb. 10, 2014, 7:17 a.m., Jonas Oscarsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115612/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 7:17 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Apply zoom level to font size, to be able to read the text not only see the icons when increasing the zoom-level.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinitemlistview.cpp 4799d76 
> 
> Diff: https://git.reviewboard.kde.org/r/115612/diff/
> 
> 
> Testing
> -------
> 
> Zoom in and out.
> 
> 
> Thanks,
> 
> Jonas Oscarsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140210/ee6beb25/attachment.htm>


More information about the kfm-devel mailing list