Review Request 115550: Simplify KItemListViewLayouter by ensuring that it always has a size hint resolver

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115550/#review49259
-----------------------------------------------------------

Ship it!


Great!

We need more such patches ;)

- Emmanuel Pescosta


On Feb. 8, 2014, 11:58 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115550/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 11:58 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> KItemListViewLayouter uses a KItemListSizeHintResolver to find out how much space the items will need in the view.
> 
> Currently, the size hint resolver object can be changed at runtime, and it can also be null. However, we never make use of these possibilities, so all the code that checks if m_sizeHintResolver is null is not needed at all. I propose to drop these options and simplify the code accordingly.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp 38ce63a 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.h 5ae4724 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp 73f3d61 
> 
> Diff: https://git.reviewboard.kde.org/r/115550/diff/
> 
> 
> Testing
> -------
> 
> The view layout still works fine in all view modes for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140208/4634b299/attachment.htm>