Review Request 112577: Created DolphinViewSignalAdapter class to get rid of DolphinMainWindow::connectViewSignals().

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112577/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 3:32 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Move the tab-handling away from DolpinMainWindow (Patch-Series)
    
Created DolphinViewSignalAdapter class to get rid of DolphinMainWindow::connectViewSignals().
    
DolphinMainWindow connects to all the signals provided by the adapter class (only once) and the
adapter class connects himself to the signals of the actual view container. When the actual
view container has been changed, the adapter class disconnects all signals to the previous
view container and connects all signals to the new view container.
    
One positive side effect is, that only the active view container's signals are processed
in the main window instead of all signals from all view containers.

We need this for the future tab handling code.


Diffs
-----

  dolphin/src/CMakeLists.txt 48ea14c 
  dolphin/src/dolphinmainwindow.h 7da5801 
  dolphin/src/dolphinmainwindow.cpp 4128cdf 
  dolphin/src/dolphinviewsignaladapter.h PRE-CREATION 
  dolphin/src/dolphinviewsignaladapter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/112577/diff/


Testing
-------

Signals like request context menu, ... work.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140205/f9a5a69c/attachment.htm>