Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information

[Gregor Mi]

> On Dec. 19, 2014, 10:13 a.m., Gregor Mi wrote:
> > dolphin/src/statusbar/spaceinfotoolsmenu.cpp, lines 109-112
> > <https://git.reviewboard.kde.org/r/121478/diff/3/?file=334818#file334818line109>
> >
> >     This fails with error message box
> >     `KDEInit could not launch '/home/gregor/dev/kf5/usr/lib64/libexec/kf5/kioexec'`
> >     Do you think this is a problem with my local runtime setup?

After a kio update the situation has improved: Filelight gets started with expected parameters. But when it is closed the same error message box appears. No error message box is shown when kdiskfree or Filelight is started without parameters.


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/#review72289
-----------------------------------------------------------


On Dec. 19, 2014, 9:34 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121478/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 9:34 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:
> 
> (1) KDiskFree
> (2) Filelight
> (3) Filelight device
> (4) Filelight location
> 
> see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png
> 
> Details on the menu entries:
> 
> (1) starts KDiskFree (useful tool, hard to find when unknown by new user)
> (2) starts Filelight without parameters
> (3) starts Filelight with current mount point
> (4) starts Filelight with current location
> 
> If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514 
>   dolphin/src/statusbar/spaceinfoexternaltools.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION 
>   dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482 
> 
> Diff: https://git.reviewboard.kde.org/r/121478/diff/
> 
> 
> Testing
> -------
> 
> Clicked all the menu entries and they work as described.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141228/3746bbc0/attachment.htm>