Review Request 121613: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121613/#review72356
-----------------------------------------------------------


Thanks for the patch :)

The current solution only fixes the problem only when you unmount the storage in Dolphin, if you try it with the device
notifier it will still block, right?

I wounder if we can use the teardownRequested(udi) from Solid::StorageAccess. (I can't find any information if this signal is triggered
before Solid checks if the storage is currently in use or if it first triggers this signal - I assume the latter one)
http://api.kde.org/frameworks-api/frameworks5-apidocs/solid/html/classSolid_1_1StorageAccess.html#a7d7d7324ab4793be41dbe43adefc910e 

We can then add a url redirection request signal in Dolphin's folder panel and go through each tab and check if the view should be redirected. 
This will replace the terminal goHome.

What do you think?

- Emmanuel Pescosta


On Dec. 20, 2014, 9:39 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121613/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2014, 9:39 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 158264
>     http://bugs.kde.org/show_bug.cgi?id=158264
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Unmounting will fail if you are currently inside the mount point with the terminal kept opened. Therfore before attempting to unmount, we need to change the directory on the terminal.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 9d4c003 
>   dolphin/src/dolphinmainwindow.cpp 95b08af 
>   dolphin/src/panels/places/placesitemmodel.h 4a374e5 
>   dolphin/src/panels/places/placesitemmodel.cpp 6accdc8 
>   dolphin/src/panels/places/placespanel.h 16112e8 
>   dolphin/src/panels/places/placespanel.cpp 720e07c 
>   dolphin/src/panels/terminal/terminalpanel.h b65239b 
>   dolphin/src/panels/terminal/terminalpanel.cpp f827503 
> 
> Diff: https://git.reviewboard.kde.org/r/121613/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work properly. Didn't find any view-terminal sync issues.
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141221/7cb4be5b/attachment.htm>