Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information

[Gregor Mi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 8:41 p.m.)


Review request for Dolphin.


Changes
-------

Thank you all for the comments. I changed the following:

- Use KService instead of findExecutable()
- Get action text from KService when possible. It uses the GenericName, e.g. it says now "View Disk Usage" instead of KDiskFree and "Disk Usage Statistics" instead of Filelight.
- Change order of menu items
- Add icons
- patch now contains four non-redundant i18n calls (instead of five with redundancy)

Screenshot 1: http://wstaw.org/m/2014/12/18/plasma-desktopkr2051.png
Screenshot when filelight is not installed: http://wstaw.org/m/2014/12/18/plasma-desktopRc2051.png


Repository: kde-baseapps


Description
-------

Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:

(1) KDiskFree
(2) Filelight
(3) Filelight device
(4) Filelight location

see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png

Details on the menu entries:

(1) starts KDiskFree (useful tool, hard to find when unknown by new user)
(2) starts Filelight without parameters
(3) starts Filelight with current mount point
(4) starts Filelight with current location

If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".


Diffs (updated)
-----

  dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514 
  dolphin/src/statusbar/spaceinfoexternaltools.h PRE-CREATION 
  dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION 
  dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION 
  dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827 
  dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482 

Diff: https://git.reviewboard.kde.org/r/121478/diff/


Testing
-------

Clicked all the menu entries and they work as described.


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141218/67f161c2/attachment.htm>