Review Request 121480: use QCollator instead of KStringHandler

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121480/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 6:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Port away from KStringHandler naturalCompare to QCollator compare.

Make use of the QCollator instance (m_collator) in nameRoleGroups instead of using QString::localeAwareCompare (uses QCollator internally) to realise a locale aware less than.

We don't need the m_caseSensitivity anymore, because the QCollator instance also holds this information.

Removed the KFileItem::name to lower conversion because this makes the case sensitive fallback sorting in stringCompare useless.

(This patch doesn't make use of QCollatorSortKey)


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.h d98d453 
  dolphin/src/kitemviews/kfileitemmodel.cpp 711b079 

Diff: https://git.reviewboard.kde.org/r/121480/diff/


Testing
-------

Natural sorting works


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141217/199057a9/attachment.htm>