Review Request 121409: Fix bug 341678 - Navigating in terminal no longer synced with view
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Dec 10 14:22:18 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121409/#review71703
-----------------------------------------------------------
+1 looks good, guessing it will only hit that code when the url is local anyway? Note that if it already is a url it will do weird things, KUrl() detected it.
You probably want to disable the default constructor of QUrl->QString->QUrl, to find these issues earlier.
- Aleix Pol Gonzalez
On Dec. 10, 2014, 2:14 p.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121409/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 2:14 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> KUrl by default sets the scheme to "file" wheras QUrl sets it to null string.
>
>
> Diffs
> -----
>
> dolphin/src/panels/terminal/terminalpanel.cpp fb7d89d
>
> Diff: https://git.reviewboard.kde.org/r/121409/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141210/ece16b8c/attachment.htm>
More information about the kfm-devel
mailing list