Review Request 121409: Fix bug 341678 - Navigating in terminal no longer synced with view

[Kai Uwe Broulik]

> On Dez. 9, 2014, 5:43 nachm., Emmanuel Pescosta wrote:
> > dolphin/src/panels/terminal/terminalpanel.cpp, lines 202-204
> > <https://git.reviewboard.kde.org/r/121409/diff/1/?file=332354#file332354line202>
> >
> >     Please use QUrl::fromLocalFile(QString).

Does that work with just a folder? I would assume its path() doesn't contain the last folder in since it will be interepreted as file?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121409/#review71662
-----------------------------------------------------------


On Dez. 9, 2014, 2:57 nachm., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121409/
> -----------------------------------------------------------
> 
> (Updated Dez. 9, 2014, 2:57 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> KUrl by default sets the scheme to "file" wheras QUrl sets it to null string.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/terminal/terminalpanel.cpp fb7d89d 
> 
> Diff: https://git.reviewboard.kde.org/r/121409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141209/2902c658/attachment.htm>