Review Request 121409: Fix bug 341678 - Navigating in terminal no longer synced with view

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121409/#review71647
-----------------------------------------------------------



dolphin/src/panels/terminal/terminalpanel.cpp
<https://git.reviewboard.kde.org/r/121409/#comment49960>

    I don't think that is what you want since you're setting it to file regardless. So what if i'm browsing some protocol other then file?
    
    I think you want something like:
    QUrl url(dir);
    if (url.scheme().isEmpty()) {
        url.setScheme("file");
    }
    emit ...


- Mark Gaiser


On dec 9, 2014, 2:57 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121409/
> -----------------------------------------------------------
> 
> (Updated dec 9, 2014, 2:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> KUrl by default sets the scheme to "file" wheras QUrl sets it to null string.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/terminal/terminalpanel.cpp fb7d89d 
> 
> Diff: https://git.reviewboard.kde.org/r/121409/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141209/4bb55d52/attachment.htm>