Review Request 121309: Letting KDirLister use the cache can lead to wrong file listing

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121309/#review71216
-----------------------------------------------------------


Heh, this workaround is definately not what you would want to use. That basically renders the cache useless.

I'm not entirely sure where the issue is in this case.

If you unmount a folder _while_ it was being opened then i "think" the watch will cease to exist because.. well.. the folder being watched is gone. KDirLister has - to my knowledge - no mechanism to watch on non existing folders, but it can be done if you're really feeling adventurous [1].

I don't know what the best solution might be, but it smells like you need to know mount events to fix it properly. Dolphin probably knows mount events already so the most simple fix would probably involve dolphin looking at mount events and currently open folders. If it finds a match (mount event + open folder) then it should reload the folder.

Just my 5 cents.

[1] https://jdennis.fedorapeople.org/lwatch/html/InotifyOverview.html

- Mark Gaiser


On dec 1, 2014, 2:39 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121309/
> -----------------------------------------------------------
> 
> (Updated dec 1, 2014, 2:39 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Steps to reproduce:
> =================
> 
> 1. `# mount something /home/foo/bar`
> 2. Open dolphin and navigate to /home/foo/bar
> 3. `# umount /home/foo/bar; sleep 1; mount something /home/foo/bar`
> 
> Dolphin will continue to show that the directory is empty until you press F5.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 72acf77 
> 
> Diff: https://git.reviewboard.kde.org/r/121309/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141201/7a9419cd/attachment.htm>