Review Request 119986: Dolphin: Rename "Recently Accessed" to "Recently Modified"

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119986/#review65521
-----------------------------------------------------------


Thanks for the patch! The bug report is https://bugs.kde.org/show_bug.cgi?id=304854 . Note that Thomas Pfeiffer from the usability team actually recommended to use the term "Saved", rather than "Accessed" or "Modified" in comment 5 of that report, and there was agreement that this idea makes sense.

(There was even an earlier patch for this issue, https://git.reviewboard.kde.org/r/113957/ , but it seems that the author neither pushed it to git.kde.org nor asked anyone else to do it for him, so it was forgotten. Your patch is better though because it also takes the documentation into account.)

- Frank Reininghaus


On Aug. 29, 2014, 11:54 a.m., kdeuser56 kdeuser56 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119986/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2014, 11:54 a.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Vishesh Handa.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> In dolphin the Section that leads you to timeline claims to show "Recently Accessed", which is not true, it shows "Recently Modified". I think this should be corrected, both in the ui and in the code, since this is very misleading.
> 
> Even if it was planned for the future to offer "Recently Accessed" this should be separated anyway from "Recently Modified" since, for a user "Recently Modified" is without any doubt the more important information and should not get lost as a subset of "Recently Accessed".
> 
> "Recently Accessed" would anyway cause a lot of trouble with the implementation since a lot of people have disabled atime, so it would not be reliable without a custom daemon watching files for access times.
> 
> The diff for the frameworks branch is attatched.
> 
> 
> Diffs
> -----
> 
>   doc/dolphin/index.docbook 5fe85f5 
>   dolphin/src/panels/places/placesitem.h 297f12d 
>   dolphin/src/panels/places/placesitem.cpp 539b926 
>   dolphin/src/panels/places/placesitemmodel.cpp dc2b95c 
>   dolphin/src/panels/places/placespanel.cpp f19fa1e 
> 
> Diff: https://git.reviewboard.kde.org/r/119986/diff/
> 
> 
> Testing
> -------
> 
> compiled and tested
> 
> 
> File Attachments
> ----------------
> 
> frameworks.diff
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/08/29/cea6e87a-2f3b-46e8-a89c-41e4cc7f70b4__frameworks-new.diff
> 
> 
> Thanks,
> 
> kdeuser56 kdeuser56
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140829/1626d02c/attachment.htm>