Review Request 119961: Only keep the active view container connected with the main window

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119961/#review65468
-----------------------------------------------------------

Ship it!


Thanks for the good analysis of this subtle bug. I agree that the solution looks good!

- Frank Reininghaus


On Aug. 27, 2014, 9 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119961/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 9 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 338549
>     http://bugs.kde.org/show_bug.cgi?id=338549
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Only keep the active view container connected with the main window, all inactive 
> view containers are disconnected. Changing the connections is done whenever
> the active view has been changed, so we can always guarantee that only the 
> active view is connected.
> 
> The problem with restoring saved sessions is, that we create a new view container
> in DolphinTabPage::restoreState() when split view was used in the previous session,
> but this view container isn't connected to the main window slots because 
> DolphinMainWindow::connectViewSignals() is not called for this container. This leads
> to these strange problems: no context menu, ...
> 
> This patch uses the "keep only one view connected"-logic from master. I think it's
> safe enough for the stable branch, because we use it for quite a while already in
> master and I haven't found any problems yet.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp db4ad07 
> 
> Diff: https://git.reviewboard.kde.org/r/119961/diff/
> 
> 
> Testing
> -------
> 
> Split view, tabs, session restoring, ... works for me :)
> 
> No problems found so far
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140829/226722a5/attachment.htm>