Review Request 119401: Hide a already visible KMessageWidget message before showing a new message

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119401/#review64996
-----------------------------------------------------------

Ship it!


Thanks, looks good and works nicely! :)

Tested with an external hard drive + network share and I can confirm that it fixes the bug.

Please commit it to branch KDE/4.14 with fixed-in version 4.14.1

- Emmanuel Pescosta


On Aug. 20, 2014, 10:45 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119401/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 10:45 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 323077
>     http://bugs.kde.org/show_bug.cgi?id=323077
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> 1. Do some operation that causes the KMessageWidget to show an error message
> 2. Immediately Repeat the same action.
> 
> The user has no way to know if the second operation failed or not.
> 
> This patch checks whether a message is currently being displayed, if so the widget is hidden before showing the new message.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 2a45152 
> 
> Diff: https://git.reviewboard.kde.org/r/119401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140821/a09fe91e/attachment.htm>