Review Request 119792: Save the view states in addition to the view urls and splitter state in DolphinTabPage.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119792/#review64945
-----------------------------------------------------------

Ship it!


Thanks, looks almost fine - feel free to push after replacing int (which may have a number of bytes that is different from 4) by the 32-bit type also when writing to the stream. Without that change, we still cannot guarantee that reading the version number that has been written by a Dolphin binary which has been compiled on a different platform will work!

I think I would have used quint32 as the type because we'll never have negative versions, but I guess we won't need the upper half of the range of quint32 in the forseeable future, so that doesn't matter much ;-) As long as the type is consitent everywhere, it's fine.


dolphin/src/dolphintabpage.cpp
<https://git.reviewboard.kde.org/r/119792/#comment45370>

    Integer type with fixed width should also be used here (AFAIK, the C++ standard does not require that 'int' has a certain number of bytes, so it's not clear which "operator >>" function will be called here).



dolphin/src/views/dolphinview.cpp
<https://git.reviewboard.kde.org/r/119792/#comment45371>

    See above (integer type with fixed width required).


- Frank Reininghaus


On Aug. 20, 2014, 7:43 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119792/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 7:43 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Save the view states in addition to the view urls and splitter state in DolphinTabPage.
> 
> Previously closed tabs can now be exactly restored. (same as in e.g. Firefox)
> 
> This is also great for session management, because you can continue your work exactly where you left it. :)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphintabpage.h de5a589 
>   dolphin/src/dolphintabpage.cpp 3d1ba5a 
>   dolphin/src/dolphintabwidget.cpp 76d4b8d 
>   dolphin/src/views/dolphinview.cpp 02b8815 
> 
> Diff: https://git.reviewboard.kde.org/r/119792/diff/
> 
> 
> Testing
> -------
> 
> 1. Expand some folders, set a item somewhere in the list as current item and scroll to a random position (also in split view)
> 2. Close this tab
> 3. Reopen the previously closed tab
> 4. Check if all previously expaned folders are expanded now (same with current item and scroll position)
> 
> Works for me!
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140820/467f3d79/attachment.htm>