Review Request 119401: Hide a already visible KMessageWidget message before showing a new message

[Emmanuel Pescosta]

> On July 22, 2014, 3:55 p.m., Frank Reininghaus wrote:
> > Thanks for the patch!
> > 
> > Could you give an example of an operation which can be used to reproduce the problem in steps 1 and 2?
> 
> Arjun Ak wrote:
>     One way to reproduce this is to setup a server serving an empty directory. Go to the URL, disconnect the network and press F5 multiple times. Now reconnect and press F5 again. Without the patch we wouldn't be able to know whether it was the last operation that failed or whether the error message is a leftover from one of the older operations. Also once the directory successfully loads the error message should be cleared.

Thanks for the instructions how to reproduce and trigger these problems, I'll try it tomorrow when I (hopefully) have time.

> Also once the directory successfully loads the error message should be cleared.

Does it also fix https://bugs.kde.org/show_bug.cgi?id=323077?


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119401/#review62885
-----------------------------------------------------------


On Aug. 20, 2014, 10:15 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119401/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 10:15 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> 1. Do some operation that causes the KMessageWidget to show an error message
> 2. Immediately Repeat the same action.
> 
> The user has no way to know if the second operation failed or not.
> 
> This patch checks whether a message is currently being displayed, if so the widget is hidden before showing the new message.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 2a45152 
> 
> Diff: https://git.reviewboard.kde.org/r/119401/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140820/a1849479/attachment.htm>