Review Request 119792: Save the view states in addition to the view urls and splitter state in DolphinTabPage.

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Aug 20 18:00:58 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119792/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 7 p.m.)


Review request for Dolphin.


Changes
-------

Added version numbers to view and tab state.

I have decided to add a deprecated method, called restoreStateV1, instead of implementing (and complicating) it in restoreState. 
This restoreStateV1 method can restore tabs from states created with Dolphin <= 4.14.x.

Thanks for your input! Great idea :)


Repository: kde-baseapps


Description
-------

Save the view states in addition to the view urls and splitter state in DolphinTabPage.

Previously closed tabs can now be exactly restored. (same as in e.g. Firefox)

This is also great for session management, because you can continue your work exactly where you left it. :)


Diffs (updated)
-----

  dolphin/src/dolphintabpage.h de5a589 
  dolphin/src/dolphintabpage.cpp 3d1ba5a 
  dolphin/src/dolphintabwidget.cpp 76d4b8d 
  dolphin/src/views/dolphinview.cpp 02b8815 

Diff: https://git.reviewboard.kde.org/r/119792/diff/


Testing
-------

1. Expand some folders, set a item somewhere in the list as current item and scroll to a random position (also in split view)
2. Close this tab
3. Reopen the previously closed tab
4. Check if all previously expaned folders are expanded now (same with current item and scroll position)

Works for me!


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140820/3223fa9c/attachment.htm>


More information about the kfm-devel mailing list