Review Request 119799: New activities linking file item plugin
Ivan Čukić
ivan.cukic at kde.org
Fri Aug 15 09:38:34 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119799/
-----------------------------------------------------------
Review request for Dolphin, Plasma and Frank Reininghaus.
Repository: kactivities
Description
-------
New version of the file item plugin for the post nepomuk era and kf5.
The behaviour is changed compared to the previous one:
- At first, it shows a submenu (named 'Activities') that contains the 'Loading...' text
- When the popup is requested to be shown (hovered signal of the root action) it asynchronously loads the sub-actions.
It is much faster than the nepomuk-based one, and it does not display the 'Loading...' item to the user at all.
Diffs
-----
src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml 919fcb2
src/lib/core/info.cpp 86fb667
src/workspace/CMakeLists.txt bd4e636
src/workspace/fileitemplugin/CMakeLists.txt d835aec
src/workspace/fileitemplugin/FileItemLinkingPlugin.h ef7ad3b
src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 5bcc141
src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 6fb9b13
Diff: https://git.reviewboard.kde.org/r/119799/diff/
Testing
-------
Tested also with artificial slowing down with sleeps.
Thanks,
Ivan Čukić
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140815/4f40b91a/attachment.htm>
More information about the kfm-devel
mailing list