Review Request 119697: React on the redirection signal from DolphinView to properly update the tab and window titles.

Frank Reininghaus frank78ac at googlemail.com
Thu Aug 14 10:09:52 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119697/#review64520
-----------------------------------------------------------

Ship it!


Thanks, looks good now, and I can confirm that it works nicely :-)

- Frank Reininghaus


On Aug. 13, 2014, 8:11 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119697/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 8:11 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 305721
>     http://bugs.kde.org/show_bug.cgi?id=305721
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> React on the redirection signal from DolphinView to properly update the tab and window titles.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 588bfda 
>   dolphin/src/dolphintabpage.h 2785247 
>   dolphin/src/dolphintabpage.cpp 23e33c9 
>   dolphin/src/dolphintabwidget.h aaadbc9 
>   dolphin/src/dolphintabwidget.cpp ea71b48 
>   dolphin/src/dolphinmainwindow.h 7bce7f1 
> 
> Diff: https://git.reviewboard.kde.org/r/119697/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140814/0d79224d/attachment.htm>


More information about the kfm-devel mailing list