Review Request 118968: Use DolphinTabPage saveState/restoreState to remember and re-open closed tabs.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118968/#review64472
-----------------------------------------------------------

Ship it!


Looks good, thanks!

- Frank Reininghaus


On Aug. 10, 2014, 6:38 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118968/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 6:38 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use DolphinTabPage saveState/restoreState to remember and re-open closed tabs.
> 
> Remembers: primary url, secondary url, splitter state, url navigator editable state and active view.
> 
> Advantages:
> * Reuse code/save-restore-logic
> * Makes testing of the tabs save-restore-logic easier ("application-level session management" ;)
> * Tabs are "properly" restored (in future we can/should also save the DolphinView states)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 0882bac 
>   dolphin/src/dolphinrecenttabsmenu.h b5acc73 
>   dolphin/src/dolphinrecenttabsmenu.cpp 2335f1b 
>   dolphin/src/dolphintabwidget.h a9bef11 
>   dolphin/src/dolphintabwidget.cpp 4bb70b4 
> 
> Diff: https://git.reviewboard.kde.org/r/118968/diff/
> 
> 
> Testing
> -------
> 
> Restoring active view doesn't work (will fixed it), but everything else works.
> 
> Closing a tab with enabled split view and modified splitter (not centered anymore) and
> reopen it in recent tabs menu restores the tab, with the two views and right splitter position.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140813/e49cfe0f/attachment.htm>