Review Request 119428: Port Dolphin accessibility to Qt 5

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119428/#review64145
-----------------------------------------------------------

Ship it!


Thank you very much!

- Frank Reininghaus


On Aug. 4, 2014, 7:18 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119428/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 7:18 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus, Sebastian Sauer, and Jeremy Whiting.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Port the accessibility implementation for the custom list views to Qt 5. Lose 90 lines of code on the way :)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt cc358a2 
>   dolphin/src/kitemviews/kitemlistview.cpp d35dd89 
>   dolphin/src/kitemviews/kitemlistviewaccessible.h c2213cd 
>   dolphin/src/kitemviews/kitemlistviewaccessible.cpp d9ddd58 
> 
> Diff: https://git.reviewboard.kde.org/r/119428/diff/
> 
> 
> Testing
> -------
> 
> Ran dolphin a few times. It works nicely with Orca.
> Make sure to run "gsettings set org.gnome.desktop.a11y.applications screen-reader-enabled true" once before testing, then Orca should just work and read Dolphin :)
> All the tedious setup from Qt 4 is gone and the code quite a bit cleaner all in all.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140810/3e48b05b/attachment.htm>