Review Request 119553: Fix dolphin warning on launch "QPixmap::scaled: Pixmap is a null pixmap"

[Michael Reeves]

> On July 31, 2014, 4:37 p.m., Frank Reininghaus wrote:
> > Thanks Michael and Kai for the patch and the comments! Looks good from my point of view.
> > 
> > Note that there will not be any more 4.13.x releases, so KDE/4.14 is the branch you want to commit this to.

Thanks I don't have commit access myself.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119553/#review63600
-----------------------------------------------------------


On July 31, 2014, 12:03 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119553/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:03 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> If dolphin is launched with the information pane on and set to display preview PixmapViewer::paintEvents seems called three times before any pixmap is set. Each time the above warning message is output.
> This does not happen if the preview feature is off when dolphin starts or if it is toggled after launch.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/pixmapviewer.cpp 8a752c5 
> 
> Diff: https://git.reviewboard.kde.org/r/119553/diff/
> 
> 
> Testing
> -------
> 
> Verfied that warings are gone and a information pane works as epected. 
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140801/77cd1440/attachment.htm>