Review Request 117794: Change the icon text for Previous and Next toolbar buttons

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117794/#review56755
-----------------------------------------------------------

Ship it!


Thanks for your patch! Looks good, we'll commit it for you. We'll commit it to the master branch though, which will become Dolphin 4.14, because the KDE/4.13 branch is frozen for new strings according to the release schedule

http://techbase.kde.org/Schedules/KDE4/4.13_Release_Schedule

About your comment in the bug report if these actions should get an icon: this would make sense, of course. I'm just not sure which icon would be good for it. AFAIK, there are no "activate next/previous tab icons" yet, and using "arrow-left" or something like that might lead to inconsistencies with other KDE applications, which might also have tabs, but use these icons for something completely different.

- Frank Reininghaus


On April 26, 2014, 6:20 p.m., Renato Atilio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117794/
> -----------------------------------------------------------
> 
> (Updated April 26, 2014, 6:20 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 332629
>     http://bugs.kde.org/show_bug.cgi?id=332629
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> In addition to the current long text for previous and next toolbar buttons ("Activate Previous/Next Tab"), I've added shorter icon texts for them to be used only on the toolbar ("Previous/Next Tab").
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 28169cf 
> 
> Diff: https://git.reviewboard.kde.org/r/117794/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Renato Atilio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140428/4075371d/attachment.htm>