Review Request 117778: Toolbar buttons for next and previous tabs do not gray out
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Fri Apr 25 22:47:02 BST 2014
> On April 25, 2014, 11:11 p.m., Emmanuel Pescosta wrote:
> > Thanks for the patch, looks good!
> >
> > Please push it to branch KDE/4.13
>
> Renato Atilio wrote:
> Thank you.
>
> I don't have push access. What should be my next step?
> Thank you.
You are welcome
> I don't have push access.
Ok we will push it for you.
You can request your own commit access after some time.
> What should be my next step?
Finished!
We have another junior job (bug 332629) ;)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117778/#review56573
-----------------------------------------------------------
On April 25, 2014, 11:22 p.m., Renato Atilio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117778/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 11:22 p.m.)
>
>
> Review request for Dolphin.
>
>
> Bugs: 332628
> http://bugs.kde.org/show_bug.cgi?id=332628
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> As discussed in the bug report, I've disabled the previous and next toolbar buttons when the last tab is closed and enabled it again when a new tab is open.
>
> Additionally I've set the initial state for both buttons as disabled.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 8473014
>
> Diff: https://git.reviewboard.kde.org/r/117778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Renato Atilio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140425/79444417/attachment.htm>
More information about the kfm-devel
mailing list