Review Request 117021: Fix Bug 332159 - dolphin does not remember scroll position when going back

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117021/#review56406
-----------------------------------------------------------


This review has been submitted with commit 4da1c81d63c19428f81a0af7cb23994c7881a675 by Emmanuel Pescosta to branch KDE/4.13.

- Commit Hook


On March 24, 2014, 3:19 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117021/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 3:19 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 332159
>     http://bugs.kde.org/show_bug.cgi?id=332159
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fix Bug 332159 - dolphin does not remember scroll position when going back
> 
> DolphinView::updateViewState will be called multiple times in some special cases,
> so we only reset the restored contents position if we have successfully reached it.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 2769d67 
> 
> Diff: https://git.reviewboard.kde.org/r/117021/diff/
> 
> 
> Testing
> -------
> 
> Works. 
> 
> See Ashish's comment #5 in the bug report:
> 
>  Ashish 2014-03-23 19:02:46 CET
> I can reproduce this only when the 1st folder has "Show hidden files" enabled. 
> Step 1: Enable Show Hideen Files in say, home folder. 
> 2: Scroll down, open any folder. 
> 3: click back. We reach the top position in home folder. When Hidden files is not enabled, clicking on back remembers the scroll position. 
> Version tested: 4.12.3 on Ubuntu 13.10
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140424/555cb73b/attachment.htm>