Review Request 117478: Convert dolphin (frameworks) to Qt5 signal/slot syntax

Thiago Macieira thiago at kde.org
Fri Apr 11 07:06:47 BST 2014


Em qui 10 abr 2014, às 13:07:13, Alexander Richardson escreveu:
> Most of this conversion was done automatically, only minor manual changes
> were needed.

Please don't do this.

There are slight behaviour differences between the two regarding delivery of 
signals when the object is being destroyed.

Unless you've analysed to verify that this situation can't happen, do not do 
automatic changes from one to the other.
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358





More information about the kfm-devel mailing list