Review Request 117478: Convert dolphin (frameworks) to Qt5 signal/slot syntax

Alexander Richardson arichardson.kde at googlemail.com
Thu Apr 10 15:55:06 BST 2014 


> On April 10, 2014, 3:27 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/dolphinmainwindow.cpp, line 1713
> > <https://git.reviewboard.kde.org/r/117478/diff/1/?file=264113#file264113line1713>
> >
> >     InformationPanel::setUrl?

Missed that one after changing the type of infoPanel to InformationPanel


> On April 10, 2014, 3:27 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/dolphinmainwindow.cpp, line 1761
> > <https://git.reviewboard.kde.org/r/117478/diff/1/?file=264113#file264113line1761>
> >
> >     TerminalPanel::setUrl?
> >     
> >     Or if you prefer Panel::setUrl then you should change FoldersPanel::setUrl to Panel::setUrl too.

Same here, if it had been a TerminalPanel* before my tool would have done this correctly.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117478/#review55373
-----------------------------------------------------------


On April 10, 2014, 3:07 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117478/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 3:07 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Requires https://git.reviewboard.kde.org/r/117395/
> 
> Most of this conversion was done automatically, only minor manual changes were needed.
> There is a problem with KAction -> QAction, since there is no longer the signal triggered() that reports the middle mouse button.
> I attempted to fix this by using QApplication::mouseButtons(), however the triggered signal is emitted after the mouse is released, so we don't get that reported anymore. Will have to investigate more how this can be fixed. This issue affects middle mouse clicking on any toolbar button. Other than that dolphin seems to work fine.
> 
> The terminal view signals could not be converted since there is no header file available that defines that signal (-> cannot get the function pointer).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b06ba01fff7cee445fcc0b896cef041bd4c34fc8 
>   dolphin/CMakeLists.txt 4b43d67e3e2144493eec8bab67dd92036062e954 
>   dolphin/src/CMakeLists.txt 3f584792d14b5491d81bb005d226c3893cff2f09 
>   dolphin/src/dolphinapplication.cpp 8e83a85928a0dadf56f5b0969c99c9f409e4d8f6 
>   dolphin/src/dolphincontextmenu.cpp f295de708f939c88917a26c67944a085eb6cbf25 
>   dolphin/src/dolphinmainwindow.h cb976129f344b9ce1886b1a8d70af3cfc46198f6 
>   dolphin/src/dolphinmainwindow.cpp 847301434b7439ddf7d6befb614cd2eda8bb7c08 
>   dolphin/src/dolphinpart.h 7146b46af375aadefbb4300f4cda950159e9e4c5 
>   dolphin/src/dolphinpart.cpp 90817319333dea9ed3bddf25e2b40ad97e926562 
>   dolphin/src/dolphinpart_ext.h c05962cd97bca5273b529b5501f34bd2eab9b85e 
>   dolphin/src/dolphinremoveaction.cpp 7d7c2f0439416f1e156ff1eabccc6de89b15dd80 
>   dolphin/src/dolphinviewcontainer.h 31612f10afc4438c9015dc04e7fd0de2e20232ca 
>   dolphin/src/dolphinviewcontainer.cpp 768fd5ef90915cee7505bb4629d69524e198858f 
>   dolphin/src/filterbar/filterbar.cpp 6de6fbe5c6ebd385f5a54d21a4a600d27bbdcfee 
>   dolphin/src/kitemviews/kfileitemlistview.cpp fd01f2c4c23565827f7ed6b1e4aaf0e3b99f141e 
>   dolphin/src/kitemviews/kfileitemmodel.cpp fd773e1e97afd1d608ba56bc0127e41b94f77a4c 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h a9e979ae1853a8d0ed37cd115f94e69790c6de0b 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40e7237ca73856420e16fc49336001f80e6 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 8498286c9f68293709b74b5a86301878b86987ee 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 7344b9960f07ec72eb7f47d6a76caa66b063d75c 
>   dolphin/src/kitemviews/kitemlistheader.cpp e89ece0a19d03433c58f1a4272587d5863b41fcf 
>   dolphin/src/kitemviews/kitemlistview.cpp 82f8a2053f2a025de19eff5cdbf6c4fc9789e64a 
>   dolphin/src/kitemviews/kitemlistwidget.cpp 85cd70c43f9e0c0ee4890ad5fa49ed9f8d756476 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9a9a734ed058e5c158a6745d2a920b2402639083 
>   dolphin/src/kitemviews/private/kdirectorycontentscounter.cpp 65afb7c3e93e645f7020c37d9256b36909c255bd 
>   dolphin/src/kitemviews/private/kfileitemclipboard.cpp faace2a3a6af822506eb2361fd3b9af25d268c73 
>   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 688ee9c5ba3825075051b6603acc63b252fef047 
>   dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 1d56894325ed968979cb31b92f5d44c0474dca4b 
>   dolphin/src/kitemviews/private/kitemlistheaderwidget.cpp 1f210ab5a862b35fdd19118ec431761184c4fb86 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 0a48f1ba0dcadfeaae3e20fe1f23abd81d7fc4e0 
>   dolphin/src/kitemviews/private/kitemlistsmoothscroller.cpp 491461b806bc438bbac6cc11e03cc0ddb7bcc943 
>   dolphin/src/kitemviews/private/kitemlistviewanimation.cpp e347c5bb113a97c7fa4eb2ec4c1f308d2dcffdb9 
>   dolphin/src/main.cpp a8e785a0d2ddbd3451a6bbb93a5230bb36dbabd4 
>   dolphin/src/panels/folders/folderspanel.cpp 46c1b34507c382dbfa396c9cd5b4edd3e9a1d3dc 
>   dolphin/src/panels/folders/treeviewcontextmenu.h 0b3fd79bd96767c2c140257059c54f9481f3ad9f 
>   dolphin/src/panels/folders/treeviewcontextmenu.cpp fa8844dfa75e29ca86395dba7a4ba71377ec34a5 
>   dolphin/src/panels/information/informationpanel.cpp eda74f3b506938c9658d12e6b2663d0f1fc124d0 
>   dolphin/src/panels/information/informationpanelcontent.cpp b2dd1582ef834f8e57649355924f5273ceba90f5 
>   dolphin/src/panels/information/phononwidget.cpp a36ada180126c6d84452aa43720d59c94b9ef82a 
>   dolphin/src/panels/information/pixmapviewer.cpp 8a752c587691b27fd5f04dd9cceb7189392766f0 
>   dolphin/src/panels/places/placesitem.cpp 41f22cce43d30aee00c3108d75a8170d4e6d7e4a 
>   dolphin/src/panels/places/placesitemeditdialog.cpp 08c910d17301a272c882c6f6bdba3aac4d0f8850 
>   dolphin/src/panels/places/placesitemmodel.cpp baa770dfdb8d1b2fc79ec313c10fbb5bc38fbd79 
>   dolphin/src/panels/places/placespanel.cpp d5308eabe1ccf366978d00a2b800cd9f5be60199 
>   dolphin/src/panels/terminal/terminalpanel.h 374476e1c054c023737b7b3b4a159fbbad707b83 
>   dolphin/src/panels/terminal/terminalpanel.cpp bfd3002f0b14315b0d2176d2d483f23bf88c5dfd 
>   dolphin/src/search/dolphinfacetswidget.cpp b7315a01c31ceae3476732d0f70a9085b7965e4b 
>   dolphin/src/search/dolphinsearchbox.cpp c178c43c7c673971fb40c0b86be6fdde8fe6bd04 
>   dolphin/src/search/filenamesearchprotocol.cpp 4d6f59fa4c608e92598a1465b80aedcbc94f343f 
>   dolphin/src/settings/additionalinfodialog.cpp e9d5f606d99e9b64c9055eec03e4010b905502a0 
>   dolphin/src/settings/applyviewpropsjob.cpp 4bc77caee77473367817842116226519470c9149 
>   dolphin/src/settings/dolphinsettingsdialog.cpp 609e2ab92d69b61bc0cdb0b478fae9076b796521 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d7cf361226339719fd2ffe39eaff5a1367 
>   dolphin/src/settings/general/configurepreviewplugindialog.cpp 3ca08dfd00c51f74db1eca6893b9f6edd2a763e1 
>   dolphin/src/settings/general/confirmationssettingspage.cpp ab23a190830befdd8272d021b9a66cfbd4d0d52d 
>   dolphin/src/settings/general/generalsettingspage.cpp 18e152880a2188e45f7942d477de3468d9f7b38f 
>   dolphin/src/settings/general/previewssettingspage.cpp 38b61b9965f5f9da9727d0fe523ee6deeedf9804 
>   dolphin/src/settings/general/statusbarsettingspage.cpp 48622ac4ca9ef945446d985d7c6369f8442f434b 
>   dolphin/src/settings/kcm/kcmdolphingeneral.cpp 26cb580f026e5a51ef17b0a2ec863b7c32bab0e6 
>   dolphin/src/settings/kcm/kcmdolphinnavigation.cpp 36345a5156b9e905e1bc89a9a0f465aace369df1 
>   dolphin/src/settings/kcm/kcmdolphinservices.cpp 6d8c76192b38472993b72fa05df067fc07886dbc 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp a7a9db36dcb0554f7a139e18f843841c19981878 
>   dolphin/src/settings/navigation/navigationsettingspage.cpp 8076d705d0acc12a03a15d166878d46f4b42f448 
>   dolphin/src/settings/serviceitemdelegate.h ea9681a5a8f7cadec318d22e5a11cd967b418dc2 
>   dolphin/src/settings/serviceitemdelegate.cpp 7538e038bd706a2f5812bca54053d6e910e8e260 
>   dolphin/src/settings/services/servicessettingspage.cpp 48e816be7dd4476082df52dd6e730b32575d48db 
>   dolphin/src/settings/startup/startupsettingspage.cpp 693826318241231c4a967b5e4d598bb3ccbb8259 
>   dolphin/src/settings/trash/trashsettingspage.cpp cd699856cd3ef160bedfcec9b3d16c67045acc09 
>   dolphin/src/settings/viewmodes/dolphinfontrequester.cpp 6cb7b992981042cf0e176589c36852586b3e0896 
>   dolphin/src/settings/viewmodes/viewsettingspage.cpp 4f8a3f00d393248319c407fffecd1bbadcea2b9c 
>   dolphin/src/settings/viewmodes/viewsettingstab.cpp bc124516de5185ed807d07776a7edcb6bc760a0c 
>   dolphin/src/settings/viewpropertiesdialog.cpp 574f8e18e437d5936020cb73dd185378fa9c4a66 
>   dolphin/src/settings/viewpropsprogressinfo.cpp 9b7797d02d61c2b7f61b1662dfaf01253938ad0e 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 671ef4f961b76219333c0832627ed38cc12a176e 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 61b28334a28969236d6af931c3c01409399cd128 
>   dolphin/src/views/dolphinitemlistview.cpp 4799d76794106e9fb7e6d89aa11e22fae27cdd3d 
>   dolphin/src/views/dolphinnewfilemenuobserver.h 239476eb9d2193d6f058fdc8be77011b6e88e096 
>   dolphin/src/views/dolphinnewfilemenuobserver.cpp 7669f15616d0615fa4f7fae58fb9c336a3340cab 
>   dolphin/src/views/dolphinremoteencoding.cpp 04b350eda78c26b3832bf1dd54a2ab6bec567bd3 
>   dolphin/src/views/dolphinview.h 3731464a35b8e5e88749908ed348e43ba183161f 
>   dolphin/src/views/dolphinview.cpp 9f5f48a86b9521ccf2e6a1de43bcd3403c8c4308 
>   dolphin/src/views/dolphinviewactionhandler.h e80ffc0dffb426b1882ec302aca99cc90fce6bc3 
>   dolphin/src/views/dolphinviewactionhandler.cpp 48ec95c70e04439c5dbe8667d96edc421e26bb9f 
>   dolphin/src/views/renamedialog.cpp d8dbd7749dc3eb7fd91b29a3dd68fb2a90f2d9cd 
>   dolphin/src/views/tooltips/filemetadatatooltip.cpp b726996641057395a29e614177c38ac6de332bec 
>   dolphin/src/views/tooltips/tooltipmanager.cpp bd6948363e58c94ce68afacc4ffb94d25b5b809e 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 6457f607dadd553c48b0944213a75ff62e80a461 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.h d12d2cfe07592d1aff3b1b8ef46d7aef3ebd2aca 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 36345d986fa839a758f283a9e4f30242c73f8526 
>   dolphin/src/views/viewproperties.cpp d4ecfafa0822d49d867aa032fcd983545cf0465d 
>   kdepasswd/CMakeLists.txt 8933049ab39801080f88d4a1f79b782d74d9787b 
>   kdepasswd/kcm/CMakeLists.txt b0600aae0aa8ee33d698cc63a4d3270bf24619e1 
>   kdepasswd/kcm/chfacedlg.h 43511f129c7fc3e35780d5905d30e949dad23284 
>   kdepasswd/kcm/chfacedlg.cpp 8e5a7684869763845329bd35ab2f2ace65e03b7c 
>   kdepasswd/kcm/chfnprocess.h c9f0700f51d0a749b43c75840c43b46ccadb538a 
>   kdepasswd/kcm/chfnprocess.cpp 43281dff2e12e41d939514667387b9877c486375 
>   kdepasswd/kcm/kcm_useraccount.desktop 70544d3dfc5366dfb30493a28c9705c61d6f6d90 
>   kdepasswd/kcm/main.cpp 49d271616ad6554e690089f7a04378ce24df4593 
>   kdepasswd/kdepasswd.cpp 866f454ed123aaa4f92901cbed8a1474c87e4cc7 
>   kdepasswd/passwd.h 29171c5f2ef15a6c5082db1c24e7599c55742903 
>   kdepasswd/passwd.cpp 1cb45b8dd4a50c2dbc9c7bd545d7ef09862b596a 
>   kdepasswd/passwddlg.h 262e485007debbb796eab488daa1b28fe079ed47 
>   kdepasswd/passwddlg.cpp c3762f57109f19eb324981db6a6a7d408223dc6e 
>   kdialog/CMakeLists.txt 7a90fa08e16dcb028d478f75978cc115aaf1a45d 
>   kdialog/kdialog.cpp 9afc53bccd1b313417e280952a208200cc444940 
>   kdialog/widgets.h 2afbed5af4917ee9c41fd9f82c257aebd9c11473 
>   kdialog/widgets.cpp c03cb5a179a054376881a4bdfcf474023ddf0209 
>   kfind/CMakeLists.txt 56f9a098218f05aeba7bf0a78e36579df207e067 
>   kfind/kdatecombo.h e88e06352449dc4d1f98e07f39ec515ec3e8ae6e 
>   kfind/kdatecombo.cpp b0b4f911f1d7ff16a25a47fb5d58405ffc05b287 
>   kfind/kfinddlg.cpp 12b3b7e7acd87a8617cbd256964890d3d0464f1e 
>   kfind/kfindtreeview.h d9d18edded5eb790e3904d4dd914d19d84cb60a6 
>   kfind/kfindtreeview.cpp b0089bd7aa2d8bd2aa8442696be3d1017fc303dd 
>   kfind/kftabdlg.cpp 529716849ed807042ab23262972821e34842de02 
>   kfind/kquery.h 39609f39f15738c00c665b34a620dedda3f07798 
>   kfind/kquery.cpp e185c1e089b7abfc5afac39ba56b25bec67272b1 
>   kfind/main.cpp 0cbafb7372c95003f53bc96fe000497810f14708 
>   lib/konq/CMakeLists.txt 8ecbfa9d33b4bc2cb3e54bc0da7ba5d2010f6964 
>   lib/konq/favicons/CMakeLists.txt 8530c4f66f4d1413f92a64bef239762985696055 
>   lib/konq/favicons/favicons.h 56bf9dbd4cea0d7a49a9fa99283fc42e2f789523 
>   lib/konq/favicons/favicons.cpp 7837773cd3be2c7d32ae3fdc63ba4fbad87eef45 
>   lib/konq/konq_copytomenu.cpp ca1d96394e11f49136524380b3f55c121c789845 
>   lib/konq/konq_dndpopupmenuplugin.h 6cfef55d164abc58e1985d252696d0f91e7de85e 
>   lib/konq/konq_events.h b2b65184e25fd0f7a42af13cf2c1c7eaa11a8cb2 
>   lib/konq/konq_fileitemcapabilities.h e41a8f84ff9fea72b5d12201d921f46b85e3b6c0 
>   lib/konq/konq_historyentry.h c9e7216aee97fdcdcf91acc22507895ea89de0fd 
>   lib/konq/konq_historyprovider.cpp 82961731d549f6fa64efe9a562f035d68d2e2746 
>   lib/konq/konq_menuactions.h ba726d75d0a99f67e79968aa1527de43aa9544b5 
>   lib/konq/konq_menuactions.cpp 39871478e4f653b01c8cd167460844c842056024 
>   lib/konq/konq_nameandurlinputdialog.cpp e6b5bb4d8f2116d1a44f78e38ce31a324f47807c 
>   lib/konq/konq_operations.h e9255c4ebf027d096dceb9df9431d9f9edc61ced 
>   lib/konq/konq_operations.cpp 781ea1e48090b7701e8933a43731f8b8d62234c1 
>   lib/konq/konq_popupmenu.h 305648728cf38c6e75a5b3e0fac7b2380a1c9344 
>   lib/konq/konq_popupmenu.cpp f9639d821042a513d0c4cfbec80b2f4191207401 
>   lib/konq/konq_popupmenuplugin.h da85480649fc4c8e4c1b3ccd932b7add3bbf8b39 
>   lib/konq/konq_statusbarmessagelabel.h 436279e6fdfb5a31a8e92de680c5feb3840e5f2f 
>   lib/konq/konqmimedata.cpp 24f7d4f37213f63afb43d615c915168bac5afa1c 
>   lib/konq/kversioncontrolplugin.h 8bc05f55f647a94ae2800c0cd2a419ac3a81f39b 
>   lib/konq/kversioncontrolplugin2.h 7ee40354060ca72fe026121d3099a37b8b24ba85 
>   lib/konq/tests/CMakeLists.txt 9affbf8476546346e98468230c1ef30abfcebe8f 
>   lib/konq/tests/konqmimedatatest.h 2bb6c5494df28b684c75a092902d50caf30085ee 
>   lib/konq/tests/konqpopupmenutest.h d01868eb1ac90973fca00621fc8dff954d4614b7 
> 
> Diff: https://git.reviewboard.kde.org/r/117478/diff/
> 
> 
> Testing
> -------
> 
> After converting all the signal/slot connections, dolphin seems to work normally.
> 
> I got a crash when moving something to trash, but I think this is because I currently don't have kio-trash on my system.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140410/39387fc8/attachment.htm>

More information about the kfm-devel mailing list