Review Request 117451: Update the "is cut" state of items if necessary

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Apr 10 01:01:32 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117451/#review55317
-----------------------------------------------------------

Ship it!


Looks good, thanks! 
It's definitely safe enough for KDE/4.12 ;)

Fixes the problem for me.

- Emmanuel Pescosta


On April 9, 2014, 6:16 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117451/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 6:16 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 332792
>     http://bugs.kde.org/show_bug.cgi?id=332792
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The icons of items which are "cut" are shown faded in the view. The "is cut" state of the widget representing an item is updated if the clipboard contents change. However, if the sort order is changed, then each widget keeps the "is cut" state of the item which had been shown previously at its position.
> 
> The solution is to update the "is cut" state also if any of the widget's data change.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp d8b5ad9 
> 
> Diff: https://git.reviewboard.kde.org/r/117451/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140410/fa0433f2/attachment.htm>


More information about the kfm-devel mailing list