Review Request 114614: Make the drag and drop error/info message handling a little bit better/more uniform.

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114614/
-----------------------------------------------------------

(Updated April 4, 2014, 6:20 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Bugs: 294054
    http://bugs.kde.org/show_bug.cgi?id=294054


Repository: kde-baseapps


Description
-------

Error messages like "Folder is not writealbe" are shown in a red message box.
Info messages like "Folder cannot be dropped on itself" are shown in the status bar.


Diffs
-----

  dolphin/src/dolphinmainwindow.h 6b046c2 
  dolphin/src/dolphinmainwindow.cpp a4dbb6f 
  dolphin/src/dolphinpart.cpp 9081731 
  dolphin/src/dolphinviewcontainer.cpp cc26198 
  dolphin/src/panels/folders/folderspanel.h 14d8e87 
  dolphin/src/panels/folders/folderspanel.cpp 46c1b34 
  dolphin/src/panels/places/placespanel.cpp d5308ea 
  dolphin/src/views/dolphinview.cpp 1416bb6 
  dolphin/src/views/draganddrophelper.h eda5fc5 
  dolphin/src/views/draganddrophelper.cpp f8ae0ad 

Diff: https://git.reviewboard.kde.org/r/114614/diff/


Testing
-------

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140404/a5b9104a/attachment.htm>