Review Request 114614: Make the drag and drop error/info message handling a little bit better/more uniform.

[Frank Reininghaus]

> On Dec. 28, 2013, 1:59 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! In principle, the idea to use a singleton to handle all drag&drop-related messages is good. However, if we had more than one DolphinMainWindow per process, it would cause each message to be shown in all windows, right?
> > 
> > Dolphin did use a single process for all windows before KDE SC 4.7. That was changed because Strigi caused Dolphin to crash a lot at that time, and it was quite annoying to see all Dolphin windows disappear if one of them crashed. Moreover, the application-modal KIO dialogs caused all Dolphin windows to freeze if a dialog was shown for one of them. There were some discussions about this issue recently, see, e.g.,
> > 
> > http://lists.kde.org/?t=137537235900004&r=1&w=2
> > 
> > Dolphin is much more stable now than it used to be, and the KIO dialogs are now window-modal thanks to Dawit's efforts:
> > 
> > https://git.reviewboard.kde.org/r/114473/
> > https://git.reviewboard.kde.org/r/114436/
> > 
> > Therefore, we could actually make Dolphin a KUniqueApplication again in 4.13. One of the benefits would be that opening a new Dolphin window would be very fast if the 'dolphin' process is running already. It might not be quite as easy as reverting
> > 
> > http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=fff7573ebb910712ad97951bf1762e6a7bb0bdc7
> > 
> > though because some of the affected code might have changed in the mean time.
> 
> Emmanuel Pescosta wrote:
>     What if we show the error messages from Drag and Drop handler, new-file-menu observer, ... always in the active Dolphin window only?
>     
>     If so, we need a "proxy" object which delegates the messages to the active window.
> 
> Emmanuel Pescosta wrote:
>     Any updates on making Dolphin a KUniqueApplication again?
>     
>     According to KF5 API docs, KUniqueApplication is only kde4support. 
>     http://api.kde.org/frameworks-api/frameworks5-apidocs/kde4support/html/classKUniqueApplication.html
>     
>     Should we really rely on it in the 4.x era, given that KF5 is almost ready to start the porting to KF5/Qt5?

The "unique" functionality is not going away, it's just going to be implemented in a different way with Qt5/KF5, and it looks like porting away from KUniqueApplication would be quite straightforward:

http://community.kde.org/Frameworks/Porting_Notes#KDEUI_Changes
http://api.kde.org/frameworks-api/frameworks5-apidocs/kdbusaddons/html/classKDBusService.html

I still think that making Dolphin a KUniqueApplication makes sense, I just did not get round to do it (a simple git revert of http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=fff7573ebb910712ad97951bf1762e6a7bb0bdc7 does not work).


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114614/#review46282
-----------------------------------------------------------


On Dec. 22, 2013, 3:55 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114614/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 3:55 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 294054
>     http://bugs.kde.org/show_bug.cgi?id=294054
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Error messages like "Folder is not writealbe" are shown in a red message box.
> Info messages like "Folder cannot be dropped on itself" are shown in the status bar.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 6b046c2 
>   dolphin/src/dolphinmainwindow.cpp a4dbb6f 
>   dolphin/src/dolphinpart.cpp 9081731 
>   dolphin/src/dolphinviewcontainer.cpp cc26198 
>   dolphin/src/panels/folders/folderspanel.h 14d8e87 
>   dolphin/src/panels/folders/folderspanel.cpp 46c1b34 
>   dolphin/src/panels/places/placespanel.cpp d5308ea 
>   dolphin/src/views/dolphinview.cpp 1416bb6 
>   dolphin/src/views/draganddrophelper.h eda5fc5 
>   dolphin/src/views/draganddrophelper.cpp f8ae0ad 
> 
> Diff: https://git.reviewboard.kde.org/r/114614/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140404/92c6a5e5/attachment.htm>