Review Request 117344: Fix crash on startup caused by Dropbox plugin

Frank Reininghaus frank78ac at googlemail.com
Thu Apr 3 08:11:48 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117344/#review54915
-----------------------------------------------------------

Ship it!


Looks good!

- Frank Reininghaus


On April 3, 2014, 12:10 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117344/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:10 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 332481
>     http://bugs.kde.org/show_bug.cgi?id=332481
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Create the item state socket on "begin retrieval" and delete it again in "end retrieval".
> 
> 
> Diffs
> -----
> 
>   dropbox/fileviewdropboxplugin.cpp 0026d59 
> 
> Diff: https://git.reviewboard.kde.org/r/117344/diff/
> 
> 
> Testing
> -------
> 
> I can't reproduce the problem but the message "(Parent is QTcpSocket(0xcebfbac), parent's thread is QThread(0xad4fb88), current thread is UpdateItemStatesThread(0x110eafa0)" doesn't appear anymore.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140403/d6610251/attachment.htm>


More information about the kfm-devel mailing list