Review Request 112962: Make sure that KFileItemModel::removeExpandedItems() also expands filtered items

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112962/
-----------------------------------------------------------

(Updated Sept. 29, 2013, 1:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

I just noticed that KFileItemModel::removeExpandedItems() fails to remove expanded items that are currently filtered, which can make expanded items re-appear incorrectly after switching from Details to Icons View.

The fix is quite straightforward - just iterate over the filtered items and remove those which have a parent.


This addresses bug 325344.
    http://bugs.kde.org/show_bug.cgi?id=325344


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.cpp b6b6ee0 
  dolphin/src/tests/kfileitemmodeltest.cpp 391fe5b 

Diff: http://git.reviewboard.kde.org/r/112962/diff/


Testing
-------

Fixes the bug for me. Old and new unit tests pass.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130929/62ee6af7/attachment.htm>