Review Request 112962: Make sure that KFileItemModel::removeExpandedItems() also expands filtered items

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112962/#review40963
-----------------------------------------------------------

Ship it!


Sry for the late response, but I was very busy for the last two weeks because I
moved to a new flat in another town - closer to Brno 2014 :)

Great and works fine!

- Emmanuel Pescosta


On Sept. 26, 2013, 9:09 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112962/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 9:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> I just noticed that KFileItemModel::removeExpandedItems() fails to remove expanded items that are currently filtered, which can make expanded items re-appear incorrectly after switching from Details to Icons View.
> 
> The fix is quite straightforward - just iterate over the filtered items and remove those which have a parent.
> 
> 
> This addresses bug 325344.
>     http://bugs.kde.org/show_bug.cgi?id=325344
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp b6b6ee0 
>   dolphin/src/tests/kfileitemmodeltest.cpp 391fe5b 
> 
> Diff: http://git.reviewboard.kde.org/r/112962/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug for me. Old and new unit tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130928/ea36357c/attachment.htm>